| |
rpm id |
test |
status |
message |
 |
klipper-0.13.0-alt1.x86_64 |
arch-dep-package-has-big-usr-share |
info |
The package has a significant amount of architecture-independent data in /usr/share, while it is an architecture-dependent package. This is wasteful of mirror space and bandwidth, as we then end up with multiple copies of this data, one for each architecture. If the data in /usr/share is not architecture-independent, it is a policy violation, and in this case, you should move that data elsewhere. |
 |
klipper-0.13.0-alt1.x86_64 |
systemd-but-no-native-init |
experimental |
The package have native systemd file(s) but no SysV init scripts. |
 |
klipper-0.13.0-alt1.x86_64 |
unsafe-tmp-usage-in-scripts |
fail |
The test discovered scripts with errors which may be used by a user for damaging important system files. For example if a script uses in its work a temp file which is created in /tmp directory, then every user can create symlinks with the same name (pattern) in this directory in order to destroy or rewrite some system or another user's files. Scripts _must_ _use_ mktemp/tempfile or must use $TMPDIR. mktemp/tempfile is safest. $TMPDIR is safer than /tmp/ because libpam-tmpdir creates a subdirectory of /tmp that is only accessible by that user, and then sets TMPDIR and other variables to that. Hence, it doesn't matter nearly as much if you create a non-random filename, because nobody but you can access it. Found error in /usr/lib/klipper/scripts/klipper-pru-start.sh: $ grep /tmp/ /usr/lib/klipper/scripts/klipper-pru-start.sh mcu_host_stop() { # Shutdown existing Klipper instance (if applicable). The goal is to # put the GPIO pins in a safe state. if [ /tmp/klipper_host_mcu ]; then log_daemon_msg "Attempting to shutdown host mcu..." set ( echo "FORCE_SHUTDOWN" > /tmp/klipper_host_mcu ) 2> /dev/null || ( log_action_msg "Firmware busy! Please shutdown Klipper and then retry." && exit 1 ) sleep 1 ( echo "FORCE_SHUTDOWN" > /tmp/klipper_host_mcu ) 2> /dev/null || ( log_action_msg "Firmware busy! Please shutdown Klipper and then retry." && exit 1 ) sleep 1 set +e fi log_daemon_msg "Stopping klipper host mcu" $NAME mcu_host_start() { [ -x $KLIPPER_HOST_MCU ] || return if [ -c /tmp/klipper_host_mcu ]; then mcu_host_stop fi log_daemon_msg "Starting klipper MCU" $NAME start-stop-daemon --start --quiet --exec $KLIPPER_HOST_MCU \ |